fix(mesonlsp): improved root detection #3775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpikedPaladin
force-pushed
the
fix-mesonlsp-root
branch
from
1febf14 to
afbd86a
Compare
justinmk
reviewed
Apr 25, 2025
justinmk
reviewed
Apr 25, 2025
SpikedPaladin
force-pushed
the
fix-mesonlsp-root
branch
2 times, most recently
from
1a3a3f7 to
c9000bb
Compare
This commit enhances root directory detection of mesonlsp language server. Current behavior: root is set on first meson file user is opened New behavior: root is set to parent of meson.build with project function call
SpikedPaladin
force-pushed
the
fix-mesonlsp-root
branch
from
c9000bb to
c4aaf0c
Compare
justinmk
reviewed
Apr 28, 2025
Comment on lines
+15
to
+23
| for line in io.lines(f) do | ||
| -- skip meson comments | ||
| if not line:match '^%s*#.*' then | ||
| local str = line:gsub('%s+', '') | ||
| if str ~= '' then | ||
| if str:match '^project%(' then | ||
| return true | ||
| else | ||
| break |
There was a problem hiding this comment.
vim.filetype.match() exists for this purpose. However,
vim.filetype.match({ filename = f, contents = 'project' })
seems to return "meson" even if the file doesn't contain "project", which isn't what you want here.
There was a problem hiding this comment.
For mesonlsp root_dir is required to be at folder with 'project' file. If root will be in different place all file will be underlined with red. I just take code from vala_ls which finds project root perfectly.
There was a problem hiding this comment.
I just take code from vala_ls which finds project root perfectly.
Yeah, I'm trying to find more concise patterns so that we don't have to maintain 10x as much code in all of these configs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enhances root directory detection of mesonlsp language server.
Current behavior:
rootis set on first meson file user is openedNew behavior:
rootis set to parent ofmeson.buildwithprojectfunction call